[SYCL] Prevent deadlock during shutdown by not holding GraphUpdate mutex
#20715
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a deadlock issue that can occur during application shutdown when Level Zero (L0) calls exit() while command enqueue operations are in progress. The fix introduces checks using GlobalHandler::instance().isOkToDefer() to avoid strict lock acquisition during shutdown scenarios.
- Adds shutdown-aware checks before attempting host memory updates
- Modifies
removeMemoryObjectcall to accept a parameter indicating whether strict locking is required - Updates assertion logic to account for potential failures during shutdown
|
|
||
| void SYCLMemObjT::updateHostMemory() { | ||
| if ((MUploadDataFunctor != nullptr) && MNeedWriteBack) | ||
| // Don't try updating host memory when stutting down. |
There was a problem hiding this comment.
Corrected spelling of 'stutting' to 'shutting'.
Suggested change
| // Don't try updating host memory when stutting down. | |
| // Don't try updating host memory when shutting down. |
| std::ignore = Result; // for no assert build | ||
|
|
||
| // removeMemoryObject might fail during shutdown because of not being | ||
| // able to hold write lock. This can happen if shutdown happen due to |
There was a problem hiding this comment.
Corrected grammar: 'shutdown happen' should be 'shutdown happens'.
Suggested change
| // able to hold write lock. This can happen if shutdown happen due to | |
| // able to hold write lock. This can happen if shutdown happens due to |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deadlock can happen if L0 calls
exit()while we are in the middle of enqueuing a command.